dell / iDRAC-Redfish-Scripting

Python and PowerShell scripting for Dell EMC PowerEdge iDRAC REST API with DMTF Redfish
GNU General Public License v2.0
598 stars 276 forks source link

No such --download option #229

Closed rowlap closed 1 year ago

rowlap commented 1 year ago

The help text for ExportHWInventoryREDFISH.py includes:

  --sharetype SHARETYPE
                        Pass in the share type of the network share. Supported
                        values: Local, NFS, CIFS, HTTP and HTTPS. Note: When
                        using Local, if you want the HW file to be auto
                        downloaded once the job is marked completed, pass in
                        argument --download also.

However there is no --download option:

$ python3 ExportHWInventoryREDFISH.py -u root -ip 192.168.44.55 --sharetype Local --download
usage: ExportHWInventoryREDFISH.py [-h] [-ip IP] [-u U] [-p P] [-x X]
                                   [--ssl SSL] [--script-examples]
                                   [--shareip SHAREIP] [--sharetype SHARETYPE]
                                   [--sharename SHARENAME]
                                   [--username USERNAME] [--password PASSWORD]
                                   [--workgroup WORKGROUP]
                                   [--filename FILENAME]
                                   [--ignorecertwarning IGNORECERTWARNING]
ExportHWInventoryREDFISH.py: error: unrecognized arguments: --download

However it seems it's not required for downloading:

- INFO, check your local directory for hardware inventory XML file "hwinv.xml"

Please tweak the --help output to better align with the script's argparse syntax. I assume there may be other scripts using --sharetype, but didn't check them all.

I'm using the latest HEAD (rev 6487cfb4be9b366e48520359ddc046623b2cdd16).

texroemer commented 1 year ago

@rowlap

Thanks for the catch, i corrected the argument help text for this script along with other scripts for export LC logs and local SA collection.

-Tex