search

dell / iDRAC-Telemetry-Reference-Tools

Reference toolset for PowerEdge telemetry metric collection and integration with analytics and visualization solutions.
https://github.com/dell/iDRAC-Telemetry-Reference-Tools
Apache License 2.0
29 stars 20 forks source link

need to run the golinter on all the files of the repo, for example #95

Closed SailM23 closed 2 years ago

SailM23 commented 2 years ago

~/go/bin/golangci-lint run cmd/redfishread/redfishread.go cmd/redfishread/redfishread.go:229:24: Error return value of r.Redfish.GetLceSSE is not checked (errcheck) go r.Redfish.GetLceSSE(eventsIn, "https://"+r.Redfish.Hostname+"/redfish/v1/SSE") ^ cmd/redfishread/redfishread.go:364:34: Error return value of dataBusService.ReceiveCommand is not checked (errcheck) go dataBusService.ReceiveCommand(commands) ^ cmd/redfishread/redfishread.go:243:2: S1023: redundant return statement (gosimple) return ^ cmd/redfishread/redfishread.go:136:2: printf: log.Printf format %s has arg eventData of wrong type github.com/dell/iDRAC-Telemetry-Reference-Tools/internal/redfish.RedfishPayload (govet) log.Printf("RedFish LifeCycle Events Found for parsing: %s\n", eventData) ^ cmd/redfishread/redfishread.go:279:3: printf: log.Println arg list ends with redundant newline (govet) log.Println("EventService not supported...\n") ^ cmd/redfishread/redfishread.go:230:2: ineffectual assignment to eventsOut (ineffassign) eventsOut := new(redfish.RedfishEvent) ^ cmd/redfishread/redfishread.go:227:38: SA4009: argument eventService is overwritten before first use (staticcheck) func getRedfishLce(r RedfishDevice, eventService redfish.RedfishPayload, dataBusService databus.DataBusService) { ^ cmd/redfishread/redfishread.go:232:2: SA4009(related information): assignment to eventService (staticcheck) eventService = eventsOut.Payload ^

SailM23 commented 2 years ago

done with PR: Fixed Linter issues in the telemetry reference tools go modules #97