search

dell / libsmbios

library for interacting with Dell SMBIOS tables
Other
192 stars 39 forks source link

Fails to find gcc.h #50

Closed hughsie closed 6 years ago

hughsie commented 6 years ago

Compiling inside flatpak I get:

In file included from /app/include/smbios_c/compat.h:27:0,
                 from /app/include/smbios_c/smi.h:22:
/app/include/smbios_c/config/get_config.h:36:39: fatal error: smbios_c/config/compiler/gcc.h: No such file or directory
 #  include LIBSMBIOS_C_COMPILER_CONFIG

Looking at the builddir I see:

$ ls build-dir/files/include/smbios_c/config/
abi_prefix.h  auto_link.h  get_config.h  msvc_prefix.h  select_compiler_config.h  suffix.h     user.h     win32.h
abi_suffix.h  gcc.h        linux.h       msvc_suffix.h  select_platform_config.h  sunpro_cc.h  visualc.h  win64.h

But select_compiler_config.h is looking for smbios_c/config/compiler/gcc.h -- i.e. with a compiler/ prefix that doesn't exist in reality. Either the gcc.h header is installed in the wrong directory (and sunpro_cc.h and visual_c.h) or the include is wrong.

hughsie commented 6 years ago

I also think the files really need to go. Who cares about sunpro now? I also can't see msvc being a realistic option.

superm1 commented 6 years ago

Alright I'm going to open a separate bug to track removing all this boost stuff because it's going to require some surgery for all the #defines produced by it. For now we'll fix your issue with that PR (which I just re-pushed, so please test again).

hughsie commented 6 years ago

Not quite:

/app/include/smbios_c/config/get_config.h:46:39: fatal error: smbios_c/config/platform/linux.h: No such file or directory

superm1 commented 6 years ago

OK, I see, some subdirectory headers too. Just got a chance to try again. Can you please retry with the updated PR?

hughsie commented 6 years ago

Can you rebase wip/superm1/fix-include against master please? It makes my life easier to build a flatpak.

superm1 commented 6 years ago

Sure thing, just did.

hughsie commented 6 years ago

Thanks, sorry to be the harbinger of doom:

/app/include/smbios_c/config/get_config.h:46:39: fatal error: smbios_c/config/platform/linux.h: No such file or directory

This exists build-dir/files/include/smbios_c/platform/linux.h but not in /config...

superm1 commented 6 years ago

< sigh > Alright I made one more change, can you try again?

hughsie commented 6 years ago

Works!