dell / omnia

An open-source toolkit for deploying and managing high performance clusters for HPC, AI, and data analytics workloads.
https://omnia-doc.readthedocs.io/en/latest/index.html
Apache License 2.0
219 stars 115 forks source link

management NIC and host NIC can be the same for sidebanded systems #604

Closed j0hnL closed 2 years ago

j0hnL commented 3 years ago

Describe the bug TASK [control_plane_common : Verify different nics] fails when management NIC and host NIC are the same.

To Reproduce Steps to reproduce the behavior: ansible control_plane.yml

Expected behavior This should not fail and allow mngmnt_network_nic == host_network_nic

Screenshots

fatal: [localhost]: FAILED! => {
    "assertion": "mngmnt_network_nic != host_network_nic",
    "changed": false,
    "evaluated_to": false,
    "msg": "Failed. Incorrect nic information. public nic, management network nic and host network nic should not be the same"
}
sujit-jadhav commented 3 years ago

@j0hnL, in case of LOM both management and host network can be same, however we need to differentiate this scenario from iDRAC Settings - Network set to Dedicated and user giving same NIC for both management and host network, this is defective scenario. May be we should introduce one more variable iDRAC-network=LOM or iDRAC-Network=dedicated. We should allow management NIC and host NIC same when iDRAC-network=LOM I feel we should do this change in devel branch not in release-1.1. This needs some more testing. @Shubhangi-dell , let's make the changes for this in devel

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

j0hnL commented 2 years ago

@sujit-jadhav @Shubhangi-dell did this already get resolved?

sujit-jadhav commented 2 years ago

@j0hnL This is not yet resolved. We will target it for 1.2

j0hnL commented 2 years ago

@sujit-jadhav is this still on target for 1.2?

sujit-jadhav commented 2 years ago

@j0hnL yes John we are targeting it for 1.2

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.