dell / omsdk

Dell EMC OpenManage Python SDK
Apache License 2.0
57 stars 20 forks source link

Bad Release (1.2.370) on PyPI #9

Open fxfitz opened 5 years ago

fxfitz commented 5 years ago

QwikContext

The 1.2.370 on PyPI does not contain what's tagged in 1.2.370-master or 1.2.730-devel. Specifically we noticed that the function update_from_repo_url is missing from iDRACUpdate.py.

Details

We're trying to use the iDRACUpdate's update_from_repo_url function, however when you pip install omsdk and it installs via the PyPI package, that function is not there (even though it is present in the git tag).

This leads me to believe that it was a bad release to PyPI.

Repro Steps

Adjust the grep command as needed depending on where your packages are installed to.

pip install omsdk
grep update_from_repo_url ~/.pyenv/versions/2.7.15/envs/testvenv/lib/python2.7/site-packages/omdrivers/lifecycle/iDRAC/iDRACUpdate.py
git clone -b v1.2.370-devel https://github.com/dell/omsdk.git 
cd omsdk
sh build.sh 1.2 370 
cd dist 
pip install omsdk-1.2.370-py2.py3-none-any.whl omdrivers-1.2.370-py2.py3-none-any.whl
grep update_from_repo_url ~/.pyenv/versions/2.7.15/envs/cyclops-ansible/lib/python2.7/site-packages/omdrivers/lifecycle/iDRAC/iDRACUpdate.py

Impact

What areas, configurations and use cases does this issue impact Is there a data loss? No

NeedBy

We would just like a properly working release pushed to PyPI.

Severity

Low

rajeevarakkal commented 4 years ago

1.2.370 on PyPi maps to latest "Master" release of omsdk ie 1.2.370_master. Where as update_from_repo_url is an recent devel changes as part of 1.2.387