search

dell / python-powerflex

Python library for PowerFlex
Apache License 2.0
19 stars 19 forks source link

Fix SP get_sdss to return correct data #23

Closed stgaver closed 1 week ago

stgaver commented 3 months ago

Fixes #22 Issue 1 - Attribute error when passing fields option to get_sdss Fix is to pass filter_fields and fields by name vs position Issue 2 - get_sdss returns ALL sds in the system vs limited to SP Fix is to properly format filter_fields to match how Sds.get() expects when filtering. Issue 3 - If filter_fields is passed to get_sdss, no SDS are returned Fix is to pop off sdsIds before creating the SDS objects

anupamaloke commented 3 months ago

tagging reviewers @Bhavneet-Sharma, @trisha-dell, @meenakshidembi691. @stgaver, could you also please sign your commits?

stgaver commented 3 months ago

@anupamaloke, I think i've signed it with the gpg key. Does it look ok now? Thanks for the pointers. We typically use gerrit/git internally and I don't operate in github on a daily basis.

anupamaloke commented 3 months ago

@stgaver, thank you for signing the commit. It is good now.