search

dellagustin / SAP_Note_Enhancer

A browser extension to Enhances SAP Note viewing. Its main feature is code highlighting of ABAP correction instructions.
https://chrome.google.com/webstore/detail/sap-note-enhancer/keibkcomemkcceddcddjdlncidohgedk
MIT License
10 stars 5 forks source link

It is not working for me.sap.com #27

Closed glauc0-work closed 3 months ago

glauc0-work commented 4 months ago

First, I would like to say Thanks for this extension. It is very helpfull!

ISSUE:

After SAP changed the domain to "me.sap.com" the extension is not working

image

dellagustin commented 4 months ago

Hello @glauc0-work , I'm glad the extension is still in use after all those years and almost zero maintenance. Thank you for reporting this. I recently retested in some of the domains I was used too when I updated it to the Chrome Manifest V3. How recent was this change? Could you please post a link to a note in this new me.sap.com domain? I'll try to look at it tomorrow, hopefully this is an easy fix.

glauc0-work commented 4 months ago

Hi @dellagustin, it is very helpfull to see colors instead texts arround the changes. :)

here you go the link: https://me.sap.com/corrins/0003171185/15841

I am not expert in these extension, but you are right. Looking at the manifest.json, there is the allowed sites that we can see in the settings.

image

dellagustin commented 4 months ago

It is quite simple to test and develop it, only minor web development skills requirement (I built it when I was learning web development 😄). If you clone the repository, you can load and "unpacked extension" at chrome://extensions/, just enable the development mode and use the "Load unpacked" button, then select the content of the folder extensionFiles. I'll take this as a hint to create some documentation. Basically, the javascript files are loaded depending on the url, and you see that on the manifest.json at the content_scripts property: https://github.com/dellagustin/SAP_Note_Enhancer/blob/2be55c3d5cdbd32aee52982dca7a6f3dbbd2dd2b/extensionFiles/manifest.json#L11

The scripts are mostly the same for all applications that show correction instructions, but there are some files that handle the specifics of each different application.

Depending on how me.sap.com works, I will need to add a new URL pattern to an existing content script property, or create a new one and a dedicated new javascript file to deal with it. Let's see.

Feel free to try it out and send a PR.

glauc0-work commented 4 months ago

That is nice! I didn't know I could load local codes to the browser. I added the new domain in the section below on the manifest.json (line 57):

image

it worked, however, now there is an issue that I have no idea what this error means. lol I am glad I could learn something about extension... now I will stop here and I hope you can have a good progress on that. Thanks for the tip.

image

image

glauc0-work commented 4 months ago

Hi @dellagustin,

it is weird. The extension is working now. I didn't do anything and neither did you (according to the commit logs). The test that I tried it was in a different computer. :/ I think you can close this issue and I'm sorry about that. It was a long temporary problem and it resolved itself lol Take care!

https://me.sap.com/corrins/0003171185/15841

image

dellagustin commented 4 months ago

Hello @glauc0-work , sorry I could not address your latest comments before, but I'm glad the problem solved itself. When I have some time I will do some tests again nevertheless, so I'll keep this issue open for now.

mbtools commented 3 months ago

FYI, version 1.11.0 is working fine with me.sap.com:

image

Also thanks from me for putting this extension together! Very helpful 👍

dellagustin commented 3 months ago

Hey @mbtools ! Nice to see you here. I did not know you were a user. I'm glad you like it. I don't know if you made the connection, but I was one of the people that worked in the production of the podcast episode about ABAPgit https://podcast.opensap.info/open-source-way/2024/05/15/abapgit/.

dellagustin commented 3 months ago

Ok, I think this was tested enough by users, so I will close this issue.

mbtools commented 3 months ago

Hey @dellagustin, I didn't cross my mind that there could have been a connection, but nice to make one!

Extensions like yours and, for example, Power Notes Searcher help me understand what's possible with extensions and study how they are implemented. So one day, I can do my own extensions. :-)