does it work in "Correction Instruction" section of SAP Note ?

dellagustin / SAP_Note_Enhancer

A browser extension to Enhances SAP Note viewing. Its main feature is code highlighting of ABAP correction instructions.

https://chrome.google.com/webstore/detail/sap-note-enhancer/keibkcomemkcceddcddjdlncidohgedk

MIT License

10 stars 5 forks source link

does it work in "Correction Instruction" section of SAP Note ? #7

Closed softy12 closed 9 years ago

softy12 commented 9 years ago

I installed this extension in chrome but it seems it doesn't work in "Correction Instruction" section of SAP Notes for me. Does it work only in case of ABAP code in text area of the Notes?

dellagustin commented 9 years ago

Hi @softy12, can you please add a screenshot of the area you mentioned as Correction Instruction" section of SAP Notes?

I'm not sure I know what you mean.

softy12 commented 9 years ago

Hi Guilherme, usually Notes that are fixing some functionality have area called "Correction Instruction". E.g. in case of the Note no 1759238 there instruction no 1528751 correction instruction1

Now when I click on 1528751 I get to the list of objects which codes were changed: correction instruction2

Finally when I click on one of the objects in the list I get into the code: correction instruction3

However the ABAP code in there is not highlighted according syntax.. Can you pls check? Maybe my setup of the Enhancer is not correct?

thanks

dellagustin commented 9 years ago

Hello @softy12,

I know what you mean, it is the part I suspected. This is currently not supported, but I will keep the issue as an enhancement.

What is currently supported is to highlight the CIs directly in the note (for some users the CI is not shown, I'm not sure why):

Or in the CI when you choose show all:

I'll try to also cover the section you mention in the near future.

dellagustin commented 9 years ago

implemented in fde9ef28a055d109facc54740da1fc151b091fd9

dellagustin commented 9 years ago

Hi @softy12, this feature was implemented in version v0.0.7 which is now available, you just have to update your installed extension.

I'm just highlighting the code though, as the blocks are already well separated in this screen, I left the background color untouched.

If this is helpful, please consider leaving a rating for the extension in the chrome web store.

Best Regards, Guilherme.

softy12 commented 9 years ago

Hi Guilherme, I tested it, it worked! Thank you, great job!