Closed tmoerkerken closed 1 month ago
@sneepstefan I know you initiated this script, so please let me know if the addition of these features are not to your liking. I can always create a separate script.
Hi Tim, I did not knew you sort of hijacked my mic selector script, so next time would you involve or notify me prior to changing it?
About the changes, I don't really see the benefit of most of the changes or is this a special version for the Apps PC? The script I have written is mainly for METEOR systems and we don't want users to be able to select different versions of Odemis, we want the published version at all times. I also don't see the benefit of a separate progress window..
Honestly I think the tool is good 'as-is' right now until we need more functionality, but that's just my opinion. If this modified version is only for the App PC then I would say it is fine.
Hi Tim, I did not knew you sort of hijacked my mic selector script, so next time would you involve or notify me prior to changing it?
About the changes, I don't really see the benefit of most of the changes or is this a special version for the Apps PC? The script I have written is mainly for METEOR systems and we don't want users to be able to select different versions of Odemis, we want the published version at all times. I also don't see the benefit of a separate progress window..
Honestly I think the tool is good 'as-is' right now until we need more functionality, but that's just my opinion. If this modified version is only for the App PC then I would say it is fine.
My bad, I tried to tag you in the comment above, but I guess it did not reach you. Will message you next time.
The changes are for the Apps PC and by default it should not change the original functionality (apart from the progress bar). The version selector is optional (default false), but necessary since some features of interest only live on the unreleased development branch.
Since Apps Specialists want to select between a large set of setups, I added the progress bar, since it takes some time to go through all the different microscope files.
If you think this setup is tricky, I can copy the script and revert all changes to the original one. Let me know what you like best!
If you think this setup is tricky, I can copy the script and revert all changes to the original one. Let me know what you like best!
I think it's fine to extend the script. There are a lot of things in common. It's important to keep the original use case in mind (see some of the desktop files in mic-odm-yaml), to make sure this doesn't affect the current users. Now, the only change for these users should be the progress bar at the beginning. I guess it's fine, as it's probably very short, but if that's annoying we could only show that progress bar if the number of files is large (for instance, > 10).
@sneepstefan , the more you're going to implement new features, the more you'll get have cases of "someone has hijacked my code!". I speak from experience! It's mostly a matter of accepting it and making sure the original workflow still works.
My bad, I tried to tag you in the comment above, but I guess it did not reach you. Will message you next time.
I am not so fond of simply 'tagging' someone when the changes could be discussed beforehand. The changes are for the Apps PC and by default it should not change the original functionality (apart from the progress bar). The version selector is optional (default false), but necessary since some features of interest only live on the unreleased development branch.
Since Apps Specialists want to select between a large set of setups, I added the progress bar, since it takes some time to go through all the different microscope files.
If you think this setup is tricky, I can copy the script and revert all changes to the original one. Let me know what you like best!
I don't think it is tricky at all, indeed if the version selector is off at default that would be fine. Regarding the progress bar I do actually like the suggestion of @pieleric showing that if the number of files to parse is quite high.
My bad, I tried to tag you in the comment above, but I guess it did not reach you. Will message you next time.
I am not so fond of simply 'tagging' someone when the changes could be discussed beforehand.
The changes are for the Apps PC and by default it should not change the original functionality (apart from the progress bar). The version selector is optional (default false), but necessary since some features of interest only live on the unreleased development branch. Since Apps Specialists want to select between a large set of setups, I added the progress bar, since it takes some time to go through all the different microscope files. If you think this setup is tricky, I can copy the script and revert all changes to the original one. Let me know what you like best!
I don't think it is tricky at all, indeed if the version selector is off at default that would be fine. Regarding the progress bar I do actually like the suggestion of @pieleric showing that if the number of files to parse is quite high.
I played around with it a little bit, and even for a smaller selection it takes a few seconds, and I would personally prefer a progress bar. To me it is not annoying so I'd suggest to keep it as is.
The goal of this PR is to make Odemis easier to access on the Application Specialist's PC. Therefore I introduce the following changes:
.desktop
application file, so that there is an easy-to-access shortcut to the scriptScreen to select version of Odemis
Progress bar (old version, text is different now)
Follow up screen (
/usr/share/odemis/sim/sparc2*
argument)