search

delmottea / libCMT

c++ port of the python code from https://github.com/gnebehay/CMT
BSD 3-Clause "New" or "Revised" License
67 stars 45 forks source link

License problem #4

Closed boris-il-forte closed 9 years ago

boris-il-forte commented 9 years ago

Hi, I'm a master degree student, and I currently work on a master thesis. I'm using your code as a starting point for my target tracking algorithm. (It's not the core o the thesis, but I need a CMT c++ implementation)

you can find my modified version of the code here https://github.com/AIRLab-POLIMI/C-SLAM/tree/master/c_tracking

I'm doing a lot of refactoring and features addition, so i want to know how to deal with your copyright note.

some questions: 1) Can I change the license to gplv3? 2) I want to extract some code in anothers source files, how do i licese them? as BSD, gplv3? and the copyright note? do you want i keep your name or not?

If you prefer, you can conctact me at: davide.tateo@mail.polimi.it

however you can answer here all my doubts, for me it's ok.

Also, if you want, I can prepare a pull request with all changes/refactoring/imrovements i've done (but some of them requires ROS, or at least a ROS header only library).

I look forward to your reply as soon as possible.

delmottea commented 9 years ago

Bsd license is compatible with gplv3, i don t know how the name must be kept in this license, so maybe just add something like "based on https://github.com/delmottea/libCMT/ in the header of modified files"

I don t want the pull request because my goal was to make a translation of the official code. I think it s better to put all your changes in another project to allow people to compare initial implementation and implementation with new features.

But i m interrested to know what you have modified (i m also working on another version with continuously added features instead of only the first frame and with background substraction to avoid adding background features)

boris-il-forte commented 9 years ago

so, I can change the license to GPLv3 to all files? and I leave you as a copyright owner? it's ok for you? if so, there's no problem. Also i will put the reference to your repository.

My changes are mainly re-engeneering of the code (some refactoring), the initial bounding box of arbitrary shape and some basic support for multy target tracking (at least feature extraction made indipendent from matching/tracking, that is the heaviest part of the algorithm).

delmottea commented 9 years ago

Yes, you can put gplv3. Just keep the reference and it s ok. When your code is available, i ll link your repository in the description so that people will be able to choose what they prefer.

boris-il-forte commented 9 years ago

ok, thanks a lot, I've just pushed the modified code. When I'll have time, I'll split the CMT code from the other part of the node (i think that ROS node will be used also for mapping... so not strictly a tracking node)

If there are some problems, just let me know ;)