search

delph-in / delphin-viz

JavaScript visualizations of various DELPH-IN structures.
http://delph-in.github.io/delphin-viz/demo/
MIT License
15 stars 4 forks source link

V3 (old) of d3.js Required #5

Open lmorgadodacosta opened 5 years ago

lmorgadodacosta commented 5 years ago

It seems that you need V3 of d3.js (now at version 5), since some of the functions used to render dmrs have been renamed.

https://stackoverflow.com/questions/38391411/what-is-the-d3-js-v4-0-equivalent-for-d3-scale-category10/38391511#38391511

goodmami commented 5 years ago

Yes, I have not been able to keep delphin-viz up to date with D3, but luckily V3 is still available, and that is what we pull in for the demo: https://github.com/delph-in/delphin-viz/blob/30f614441b57b3483aa8eb2517f303b13b309c2f/demo/index.html#L15

I think at a minimum we should mention the version requirement on the README, but it would be great if someone could refresh the visualization function to use V5 of d3.js (or, even better, harmonize all visualizers to the same framework, whether it's D3 or something else).

ned2 commented 5 years ago

OK, so step one, we need to document the version requirements.

I agree it would be nice to get all the components using the same framework (and I think D3 is likely to be the right choice). This is something I could work on, but I'm fairly time-limited at the moment, so that could be a while off.

@goodmami, one thing I had been wondering about is the synchronisation of your DMRS visualizer code. It lives somewhere else, and we just have a dump of a particular version right? Might there be a more sensible way of doing this?

goodmami commented 5 years ago

@ned2 the visualizer code here was copied from Demophin, where it still is kept separate for no reason other than I haven't updated Demophin... but I don't really plan to; I think it should be deprecated in favor of delphin-viz. Therefore, the delphin-viz version of dmrs.js is now the canonical version.

ned2 commented 5 years ago

Great, good to know! That certainly keeps things simpler too.

On Sun, 23 Sep 2018 at 12:29, Michael Wayne Goodman < notifications@github.com> wrote:

@ned2 https://github.com/ned2 the visualizer code here was copied from Demophin, where it still is kept separate for no reason other than I haven't updated Demophin... but I don't really plan to; I think it should be deprecated in favor of delphin-viz. Therefore, the delphin-viz version of dmrs.js is now the canonical version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/delph-in/delphin-viz/issues/5#issuecomment-423787122, or mute the thread https://github.com/notifications/unsubscribe-auth/ACs1GNzWCzaI8nFXSBebZGp3oWN_HBUzks5udvILgaJpZM4W1hah .

-- nedned.net