search

delph-in / matrix

The Grammar Matrix
https://matrix.ling.washington.edu/index.html
Other
12 stars 6 forks source link

ICONS, valence change, and argument drop not working together #492

Open olzama opened 4 years ago

olzama commented 4 years ago

This may or may not be a separate issue from https://github.com/delph-in/matrix/issues/485

The fix for argument drop rules which passes up the dropped subject ICONS-KEY seems to work for everything except the valence change test which drops both subject and object (and the verb had changed valence prior to that).

I'd prefer to merge in the fix because it updates quite a few old MRSs with proper ICONS, and deal with this remaining issue separately (not to mention that it might actually be a separate issue, so, perhaps the fix is needed not in argument drop rules but in valence change rules).

olzama commented 4 years ago

As a separate note, the subject drop and the object drop rules right now are not completely consistent (wrt each other) in what they do, which should be investigated at some point. See https://delphinqa.ling.washington.edu/t/what-should-the-icons-look-like-in-argument-drop-was-in-a-clausalmod-sentence/544/21?u=olzama