delph-in / matrix

The Grammar Matrix
https://matrix.ling.washington.edu/index.html
Other
12 stars 6 forks source link

Fix-686 val change pass #687

Closed KerenR3 closed 8 months ago

KerenR3 commented 1 year ago

This pull request address #686. It adds a new function to valence_change.py to deal with subject-demoting and object-promoting operations where arguments are not added. This works alongside the added_argnum_for_vchop function which does the same job, but assumes an added argument. Additionally, this pull request adds extra validation warnings and errors to morphotactics.py to prevent problems with the new function. Also, since this new function allows for ditransitives formed from other valence-changing operations to be passivized, the option is added to matrixdef for the user to select ditransitive targets, but only for subj-dem or obj-prom operations. The pull request also adds relevant regression tests.