search

delph-in / matrix

The Grammar Matrix
https://matrix.ling.washington.edu/index.html
Other
12 stars 6 forks source link

warn validation on det preds + suggestion, tests #754

Closed ajcassell closed 3 weeks ago

ajcassell commented 3 weeks ago

415 Don't autofill det preds, add suggestion, validation and tests

I made this validation a warn since all predicates are technically (as of right now) not validated for form so I wasn't sure whether blocking a user from making a freeform pred was a good idea.

Screen Shot 2024-10-19 at 3 06 50 PM Screen Shot 2024-10-19 at 3 06 41 PM
emilymbender commented 3 weeks ago

Since exist_q_rel and all_q_rel are grammar preds, they should not have the leading underscore.

emilymbender commented 3 weeks ago

And the idea to make this a warning rather than an error makes sense.

ajcassell commented 3 weeks ago

Ok, I have updated to not have the leading underscore.

emilymbender commented 3 weeks ago

I think the regex should allow for both leading underscore & not. But the suggested form for exist_q_rel and all_q_rel shouldn't have one.

ajcassell commented 3 weeks ago

Got it - I take it you merged this / the code is alright because the updated regex using . will handle _. and .*?

emilymbender commented 3 weeks ago

Correct.