search

delphidabbler / codesnip

A code bank designed with Pascal in mind
https://delphidabbler.com/software/codesnip
Other
110 stars 33 forks source link

Bugs in `UVersionInfo` unit #117

Closed delphidabbler closed 1 year ago

delphidabbler commented 1 year ago

The TVersionInfo.FileVersionNumberStr and TVersionInfo.ProductVersionNumberStr methods both access the wrong version information. They access the file version and product version fixed file info fields, which automatically cast to string, instead of the string information items they are intended to access.

delphidabbler commented 1 year ago

In addition there's much use of the with statement in the unit. These really need to go!

delphidabbler commented 1 year ago

Just checked this again and, in fact, the methods are correct.

Closing this issue as invalid.

However, the with statement really does need to be removed, so opening a new issue for that.