search

delphix-integrations / terraform-provider-delphix

Repository for Delphix Terraform Provider built on DCT APIs.
https://integrations.delphix.com
11 stars 9 forks source link

Oracle dsource Creation/Deletion #72

Closed ankit-patil-hubs closed 12 months ago

ankit-patil-hubs commented 1 year ago

Problem:

Support for Oracle dsource Creation/Deletion

Solution:

Oracle dsource Creation/Deletion Updated method create/update/delete names to reuse for both appdata and oracle dsource

Testing

Manually tested on oracle rac and non rac setup

(base) ankit.patil@Ankit-Patils-MacBook-Pro terraform-provider-delphix % TF_ACC=1 go test $(go list ./... | grep -v 'vendor') -v -run TestOracleDsource_create_positive -timeout 120m ? terraform-provider-delphix [no test files] === RUN TestOracleDsource_create_positive [DELPHIX] [INFO] 2023/11/01 13:55:25 DCT-JobId:b3bda6babd8441d0aa981e76ddf584ad has Status:STARTED [DELPHIX] [INFO] 2023/11/01 13:55:31 DCT-JobId:b3bda6babd8441d0aa981e76ddf584ad has Status:STARTED [DELPHIX] [INFO] 2023/11/01 13:55:36 DCT-JobId:b3bda6babd8441d0aa981e76ddf584ad has Status:COMPLETED [DELPHIX] [INFO] 2023/11/01 13:55:36 Job result is COMPLETED [DELPHIX] [INFO] 2023/11/01 13:55:37 [OK] Breaking poll - Status 200 reached. [DELPHIX] [INFO] 2023/11/01 13:55:43 [OK] Breaking poll - Status 200 reached. [DELPHIX] [INFO] 2023/11/01 13:55:48 [OK] Breaking poll - Status 200 reached. [DELPHIX] [INFO] 2023/11/01 13:56:04 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED [DELPHIX] [INFO] 2023/11/01 13:56:10 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED [DELPHIX] [INFO] 2023/11/01 13:56:16 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED [DELPHIX] [INFO] 2023/11/01 13:56:22 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED [DELPHIX] [INFO] 2023/11/01 13:56:28 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:STARTED [DELPHIX] [INFO] 2023/11/01 13:56:34 DCT-JobId:331e3be1b2794efdb2108eb0a8fb861a has Status:COMPLETED [DELPHIX] [INFO] 2023/11/01 13:56:34 Job result is COMPLETED [DELPHIX] [INFO] 2023/11/01 13:56:35 [OK] Breaking poll - Status 404 reached. --- PASS: TestOracleDsource_create_positive (93.81s) PASS ok terraform-provider-delphix/internal/provider 95.822s

nick-mathison commented 1 year ago

Left various documentation comments.

Nothing is blocking, but we aren't really clear that the documentation presented is specifically for the Oracle dSource. We'll need to make a couple changes on the PostgreSQL docs now that we support Oracle too.