delphix-integrations / terraform-provider-delphix

Repository for Delphix Terraform Provider built on DCT APIs.
https://integrations.delphix.com
11 stars 9 forks source link

ESCL-4870 : Terraform dsource provider doesn't support ignore_changes in the lifecycle block #85

Closed ankit-patil-hubs closed 7 months ago

ankit-patil-hubs commented 7 months ago

Problem:

As per the discussion with customer, they have noticed intermittently that storage_size keeps changing even tough the dsource is disabled and this causes their TF plan to fail,when we tried to reproduce locally we don't see an issue as storage_size is a computed field , but customers are using github actions where between the TF plan and TF apply stage if any attribute changes the next steps fail .

They tried adding storage_size to theignore_changes = [storage_size] block which is a feature provided by Terraform to ignore variables in a particular lifecycle but it only works on non-computed attributes , we have defined storage_size as computed so this does not solve the problem for them.

Solution:

As storage_size is not important for infra as code, at this point, this looks like a good solution to remove this attribute and later reintroduce it if required .

Testing

dsoruce in 3.1.0 -> storage_size is available

image

upgrade to 3.2.2 -> storage_size removed post plan and apply

image

Manually Tested