delphix-integrations / terraform-provider-delphix

Repository for Delphix Terraform Provider built on DCT APIs.
https://integrations.delphix.com
11 stars 9 forks source link

Feat/add masked flag to tf provider #88

Closed rafaribe closed 4 months ago

rafaribe commented 4 months ago

Context:

I want to be able to provision Masked VDB's via the terraform provider, the API has a masked flag that allows a user to mark the VDB as masked, but the terraform provider didn't had that option.

Problem:

Terraform provider won't allow masked VDB's to be created while the API would.

Solution:

Add masked as a flag to the VDB resource int he terraform provider to allow the TF provider to pass this flag along to the DCT API.

Testing

We hot-replaced the binary for the provider with a compiled version that I created and tested it with DCT version 16.0.0.0

Implementation:

Simple implementation, I just added the masking flag to VDB's for snapshot, timestamp or bookmark provision_type auxiliary methods and therefore the provisioning for masked VDB's works across all three types.

Uddipaan-Hazarika commented 4 months ago

Changing the base to develop branch. We are in the process of reviewing it, we will review it and merge it and will let you know. Thanks

rafaribe commented 4 months ago

Any updates on this matter?

Thanks

Uddipaan-Hazarika commented 4 months ago

Hi Yes, @rafaribe the change looks good to me. I will approve the change. We will proceeding with our standard tests and regression procedure.