This repository contains the code used to build the Ubuntu-based Delphix Appliance, leveraging open-source tools such as Debian's live-build, Docker, Ansible, OpenZFS, and others.
Apache License 2.0
19
stars
41
forks
source link
DLPX-85904 Remove hardcoded git branch from appliance-build #726
This repo contains a file with a hardcoded value for the upstream/product branch. During release activities,
the release team has a script (git-merge-repos) that replaces this value for each branch as part of the merge from 1 branch to the other. To automate these merges, this value should be removed and inferred at runtime such that the logic
to replace values during release merges can also be removed.
Solution
Just like https://github.com/delphix/linux-pkg/pull/275, remove the hardcoded value and infer it at runtime only if needed.
Testing Done
ab-pre-push with devops-gate changes: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/5715/
ab-pre-push --no-tests: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/5728/
This repo contains a file with a hardcoded value for the upstream/product branch. During release activities, the release team has a script (git-merge-repos) that replaces this value for each branch as part of the merge from 1 branch to the other. To automate these merges, this value should be removed and inferred at runtime such that the logic to replace values during release merges can also be removed.Problem
Just like https://github.com/delphix/linux-pkg/pull/275, remove the hardcoded value and infer it at runtime only if needed.Solution
ab-pre-push with devops-gate changes: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/5715/ ab-pre-push --no-tests: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/5728/Testing Done