search

delphix / appliance-build

This repository contains the code used to build the Ubuntu-based Delphix Appliance, leveraging open-source tools such as Debian's live-build, Docker, Ansible, OpenZFS, and others.
Apache License 2.0
19 stars 41 forks source link

DLPX-87206 Remove optional ovf:size attribute from OVF template #733

Closed palash-gandhi closed 9 months ago

palash-gandhi commented 1 year ago

Problem

From a review comment in https://github.com/delphix/appliance-build/pull/732 , we realized that the ovf:size attribute in the OVF file was optional. The value of this field prior to https://delphix.atlassian.net/browse/DLPX-87038 differed causing issues in certain deployments. This change tracks the work to remove the optional field to eliminate the possibility of such differences. I had auto merge enabled on the previous PR which is why I am opening a new PR now that I have tested that removing the field works.

Solution

Remove the field.

Testing Done

ab-pre-push: http://selfservice.jenkins.delphix.com/job/appliance-build-orchestrator-pre-push/6407/ Verified that the field no longer exists in the OVF file of the resulting OVA: ``` (py3) [Tue Aug 01, 10:17:02] ~/Desktop $ tar -xvf external-standard-esx.ova x external-standard-esx.ovf x external-standard-esx.mf x external-standard-esx.vmdk (py3) [Tue Aug 01, 10:17:11] ~/Desktop $ grep ovf:size external-standard-esx.ovf (py3) [Tue Aug 01, 10:21:45] ~/Desktop ``` Imported the OVA into an ESX host and verified that the engine was deployed successfully: https://qa-esxi01.delphix.com/ui/#/host/vms/1589 http://172.16.96.88/
palash-gandhi commented 9 months ago

We do not have the infrastructure and licenses to test this change.