search

delphix / appliance-build

This repository contains the code used to build the Ubuntu-based Delphix Appliance, leveraging open-source tools such as Debian's live-build, Docker, Ansible, OpenZFS, and others.
Apache License 2.0
19 stars 41 forks source link

Add tab completion, path modifications #746

Closed pcd1193182 closed 10 months ago

pcd1193182 commented 10 months ago

Problem

Interacting with the systemctl command line tools can be cumbersome. Finding what services exist and are active can require grepping the output of commands that are not intended for machine parsing. Remembering and entering the full names of commands is potentially cumbersome if you don't use them regularly. There are tab completion scripts that intend to solve these problems. We also have similar problems with the zfs command line tools and the /opt/delphix/server/bin path. These things add small friction to countless processes that can be easily reduced.

Solution

We add tab completion scripts to the standard location for them on ubuntu systems, and then source those scripts to get their functionality. We also add the /opt/delphix path to the delphix user's PATH variable.

Testing Done

Spun up a development VM with these changes and verified that they all performed as expected.
prakashsurya commented 10 months ago

Shouldn't we put this in delphix-platform, so it works for existing engines after an upgrade? This will just do it for new installs..