search

delphix / linux-pkg

Framework to build custom packages for the Delphix Appliance
Apache License 2.0
4 stars 31 forks source link

TOOL-20228 pre-cutover: linux-pkg changes for new branch naming #278

Closed palash-gandhi closed 1 year ago

palash-gandhi commented 1 year ago

Problem

For the pregitflow project, I have created `develop`, `release` and `patch` branches in all product repos. I have also created a 3rd linux package mirror with changes required for the renaming of the branches. For more details, see this document: https://docs.google.com/document/d/1tHvLnX6jORHoeZqvwPP11eq-zc2usf3QyRaADCZTvEs The production mirror's URL is hardcoded at a couple of places in this repo. To build and test the product from these pregitflow branches, linux-pkg should point to the test mirror when building any of these 3 branches.

Solution

Point linux-pkg to the test mirror when building pregitflow branches. My current plan is to build these branches on a regular cadence, which is why I would like to merge this into 6.0/stage so that it also gets pushed to the `develop` branch. This change will be reverted on the day of the cutover (when development shifts to these pregitflow branches).

Testing Done

build-packages on `develop`: http://ops.jenkins-palashgandhi.dcol2.delphix.com/job/linux-pkg/job/develop/job/build-packages/job/post-push/8/console Verified that child build-package jobs point to test mirror: ``` 09:57:31 Running: sudo apt-get update 09:57:31 Get:1 http://10.110.143.13/develop/849fa250/ubuntu focal InRelease [265 kB] ``` build-packages on `6.0/stage`: http://ops.jenkins-palashgandhi.dcol2.delphix.com/job/linux-pkg/job/6.0/job/stage/job/build-packages/job/post-push/1/console Verified that child build-package jobs point to production mirror: ``` 10:11:51 Running: sudo apt-get update 10:11:51 Hit:1 http://linux-package-mirror.delphix.com/6.0/stage/cbb97c65/ubuntu focal InRelease ```
palash-gandhi commented 1 year ago

I'll approve, but can you comment on why we need this logic to land on 6.0/stage?

I feel like this could live only in the develop branch for testing that specific branch.. presumably the reasoning has something to do with how you'll be keeping the 6.0/stage and develop branches in-sync.. but I'm not sure that's a good reason to be making changes to 6.0/stage..

I'm not necessarily opposed to doing it this way, just asking so we could at least document why it's being done this way..

You're right, we won't need this change. I am now going to run a script on the prod mirror as part of https://github.com/delphix/devops-gate/pull/571. I am closing this PR.