search

delphix / linux-pkg

Framework to build custom packages for the Delphix Appliance
Apache License 2.0
4 stars 31 forks source link

TOOL-21304 Add support for delphix-go repository to linux-pkg #287

Closed pcd1193182 closed 1 year ago

pcd1193182 commented 1 year ago

This change introduces the new delphix-go package into the linux-pkg repository so that the go compiler will be installed on dev VMs. It was tested in conjunction with corresponding changes to appliance-build and devops-gate. ab-pre-push was run here and the resulting VM had the GO sdk installed correctly and could be used for zfs builds.

pcd1193182 commented 1 year ago

I think you also need to add this package to the package-lists/build/main.pkgs file.. similar to the ZFS dependency comment.. that could cause build failures until the delphix-go package is successfully built.

I believe it is added in this PR as well. Personally I think I'm fine with transient failures as a result of everything spinning up, but it's good to raise that it's likely to happen so we can plan for it. We can also probably mitigate it by integrating the delphix-go changes and devops-gate changes first?

prakashsurya commented 1 year ago

I believe it is added in this PR as well

shoot.. you're right :+1:

Personally I think I'm fine with transient failures as a result of everything spinning up

cool with me..

We can also probably mitigate it by integrating the delphix-go changes and devops-gate changes first?

yea, I'd try and land things in dependency order as much as you can..

  1. devops-gate (no dependencies, repository already created)
  2. delphix-go (independent, but PR checks required from 1)
  3. linux-pkg (depends on build logic from 2)
  4. appliance-build (depends on package from 3)

you might need to manually trigger the build after (3), so the package gets built the first time..