delphix / linux-pkg

Framework to build custom packages for the Delphix Appliance
Apache License 2.0
4 stars 31 forks source link

TOOL-24368 Use grub packages provided by Ubuntu #306

Closed prakashsurya closed 9 months ago

prakashsurya commented 10 months ago

Context

We used to have a "boot counter" implemented in GRUB, such that we could detect "reboot loops" (e.g. repeated failures to boot) and automatically boot into an alternate root filesystem which we called the "recovery environment". We've since abandoned that feature, and thus, we can migrate back to using Ubuntu's grub package(s).

Additionally, this was sparked due to the sporadic GRUB boot failures we've seen on customer engines. While we don't have any evidence to support our locally modified of GRUB is causing the boot failures, this change eliminates this as a possibility, and gets us back to using the packages built and tested by Ubuntu.

Testing

prakashsurya commented 10 months ago

do we feel comfortable pushing this 6 days before CC or are we better off integrating this as soon as 20.0 opens up?

I can wait for 20.0.. I think that's fine, and makes sense for a largely untested change like this.