Open DCSTOLF opened 1 year ago
add checks for mysql version, changes alter user syntax in case it's 8 or greater. fixes mysql parameter regex in schema.json.
alter user
the current version of the plugin will break with mysql 8 or mariadb.
it also doesn't accept valid mysql parameter names and values.
mysqld --version
The MySQL version needs to be checked so the alter user command is built properly and the plugin doesn't break completely if it's version 8.
The repository parsing needs to check for MySQL or MariaDB so it won't break if it's MariaDB.
Fixing regex so it accepts dashes on property name and dashes or periods in property value.
Tested on my lab and at a customer who's trying delphix on mysql.
Customer is not entitled to select connector, but these are easy fixes that will benefit any customer.
Closing this PR to fix secret scanning issue using BFG. Will reopen once done
Reopening the PR as BFG tool activity is done
add checks for mysql version, changes
alter user
syntax in case it's 8 or greater. fixes mysql parameter regex in schema.json.Background
the current version of the plugin will break with mysql 8 or mariadb.
it also doesn't accept valid mysql parameter names and values.
Problem
alter user
command used when creating a staging database or vdb is different on MySQL 8.mysqld --version
and it's MariaDBSolution
The MySQL version needs to be checked so the
alter user
command is built properly and the plugin doesn't break completely if it's version 8.The repository parsing needs to check for MySQL or MariaDB so it won't break if it's MariaDB.
Fixing regex so it accepts dashes on property name and dashes or periods in property value.
Testing Done
Tested on my lab and at a customer who's trying delphix on mysql.
Notes to Reviewers
Customer is not entitled to select connector, but these are easy fixes that will benefit any customer.