search

delphix / virtualization-sdk

Delphix vSDK.
Apache License 2.0
7 stars 25 forks source link

CP-6006 Futurize vSDK - Stage 1 #404

Closed mrburke closed 3 years ago

mrburke commented 3 years ago

Context:

This change begins preparing for the move to Python3.8 by running futurize --stage1 ... against all 5 packages (very few changes), and by using six to remove all direct references to basestring in the source code. CP-6009 will handle all other vSDK changes for this project. In Py2, six.string_types = [basestring] and in Py3, six.string_types = [str]. This will also take a little bit of weight off of the upcoming CP-6009 review, which can then focus mainly on introducing to_str and to_bytes helpers across the repo as necessary.

Testing

Blackbox: virtualization_sdk appdata_basic and unit tests passed

mrburke commented 3 years ago

Could you please check tools/..../exceptions.py - SchemaValidationError to see if any of the code added to parse the unicode encoded string/s from jsonschema validation errors needs a change?

Just commenting to reflect that we spoke offline, CP-6009 will cover the types of changes mentioned by Ravi above