search

delphix / virtualization-sdk

Delphix vSDK.
Apache License 2.0
7 stars 25 forks source link

CP-10040 High Severity alert on Pymdown-extensions versions lesser than 10.0 #464

Closed SumoSourabh closed 1 year ago

SumoSourabh commented 1 year ago

Problem

A High Severity alert was raised by DependenBot as per PR - https://github.com/delphix/virtualization-sdk/pull/462, which asks to update the Pymdown-extensions to 10.0.0.

Solution

Updated all the dependencies to the latest version. It includes

Updating the mkdocs-material to latest version required us to update the mkdocs.yml also as the primary Delphix color started breaking. We do provide custom palette for Delphix, but we were not mentioning it specifically anywhere. The change include mentioning the custom palette in mkdocs.yml.

More Info - https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/?h=pale#customization

Testing Done

All the changes are available at - https://sumosourabh.github.io/virtualization-sdk/

Also, tested the link using linkcheck. I have to add https://twitter.com/delphix to linkcheck-skip.txt (we already have other social accounts) as it was not getting accessed.

For requests dependency change, Manually tested

Automation Tests

Bonus

We did resolve one more PR https://github.com/delphix/virtualization-sdk/pull/463 which asks us to update requests.