Rebase our fork onto 8.3.0 - Githubissues

delta-cs / seminar-domjudge

DOMjudge programming contest jury system

https://www.domjudge.org

GNU General Public License v2.0

2 stars 0 forks source link

Rebase our fork onto 8.3.0 #147

Open zapotocnylubos opened 3 weeks ago

zapotocnylubos commented 3 weeks ago

The 8.3.0 was released 2 weeks ago.

After confirming our rebased fork works on 8.2.3 (#135), I would like to rebase our commits again onto 8.3.0.

This should also solve

https://github.com/delta-cs/seminar-domjudge/issues/138
adding Rust language
...

The complete diff can be seen here https://github.com/DOMjudge/domjudge/compare/8.2.3...8.3.0

zapotocnylubos commented 2 weeks ago

Following #135

zapotocnylubos commented 2 weeks ago

Increase the configuration name length to 64 (0617a56d), which is no longer needed. -> Extension to 64 is already included in the 8.3.0 ==>, not including that commit in our 8.3.0 branch
same for 984f3731
same for 4163dc46

zapotocnylubos commented 2 weeks ago

this should be no longer needed 7de408f0
same for b707875a

zapotocnylubos commented 2 weeks ago

[ ] regenerate composer.lock

I included the .json dependency for "setono/editorjs-php": "*", (later "setono/editorjs-php": "0.1.2",) but the .lock need to be regenerated

zapotocnylubos commented 2 weeks ago

[ ] BlogController and other custom controllers/models will need to be rewritten using PHP attributes, not comment annotations

Example

@Route("", name="public_blog_list")

to

#[Route(path: '', name: 'public_blog_list')]

zapotocnylubos commented 2 weeks ago

maybe there will be a problem with 0ccfa997

the function became abstract, wind the current implementation and add ->orderBy('c.ranknumber')
added

Same for 288f9091

not added?

zapotocnylubos commented 2 weeks ago

Is this correct? @matous-volf

{{ submission.judgings.first.pointsScored }}/{{ submission.contestProblem.points }}

in 755e6594 (original)

The run/submission can have re-judgings etc...

zapotocnylubos commented 2 weeks ago

problemtextType changed to problemstatementType

I know I've used it in the online code editor, so I think it will be broken.

zapotocnylubos commented 2 weeks ago

ok, basic rebase/cherrypicking from our current branch is completed on https://github.com/delta-cs/seminar-domjudge/tree/8.3.0

precisely https://github.com/delta-cs/seminar-domjudge/tree/7c24e4ed0f6a1f2f4ba987d7270703bafb536ab6

Now, we need to

run the local version of this branch,
fix all problems,
test on the staging environment,
and release It on production next month.