search

delta-incubator / delta-dotnet

DeltaLake bindings for dotnet based on delta-rs
Apache License 2.0
25 stars 6 forks source link

update nuget package name and delta-rs version #78

Closed mightyshazam closed 1 month ago

mightyshazam commented 1 month ago
github-actions[bot] commented 1 month ago

LCOV of commit c79e023 during Continuous Integration #137

Summary coverage rate:
  lines......: 90.7% (759 of 837 lines)
  functions..: 90.8% (168 of 185 functions)
  branches...: 76.2% (144 of 189 branches)

Files changed coverage rate: n/a
mdrakiburrahman commented 1 month ago

FYI - many files seem to have a hidden CRLF-type change that may have snuck in, makes it a bit harder to review the diffs

mightyshazam commented 1 month ago

FYI - many files seem to have a hidden CRLF-type change that may have snuck in, makes it a bit harder to review the diffs

I ran dotnet format and got an unpleasant surprise. However, there is only one change in the .net code. That change was to change table configuration from Dictionary<string, string?> to Dictionary<string, string>. All of the other changes are in the rust code and the .github folder

mdrakiburrahman commented 1 month ago

Makes sense!

One way we could solve the problem by enforcing linting in future for PR's we can setup dotnet format against it in the CI pipeline, and fail on untracked files (by comparing the git hashes of what the author put up).

(This way, whatever is in main is always linted).