search

delta-incubator / delta-kernel-rs

A native Delta implementation for integration with any query engine
Apache License 2.0
121 stars 32 forks source link

Fix column name for protocol in P&M query #343

Closed OussamaSaoudi-db closed 1 week ago

OussamaSaoudi-db commented 1 week ago

This is a followup to this PR which patches a mistake in the filter. Protocol has a protocol.minReaderVersion, and no protocol.min_reader_version field.

This PR also fixes an intermittent test failure caused by repeat initialization of tracing. This PR changes the test_scan_data test to instead use the test_log crate for initializing logs.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.03%. Comparing base (1a66fb9) to head (e0ba49a). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/scan/mod.rs 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #343 +/- ## ========================================== - Coverage 74.08% 74.03% -0.06% ========================================== Files 43 43 Lines 8154 8137 -17 Branches 8154 8137 -17 ========================================== - Hits 6041 6024 -17 Misses 1733 1733 Partials 380 380 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.