Open nicklan opened 1 week ago
Attention: Patch coverage is 93.54839%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 74.12%. Comparing base (
b3a3b7d
) to head (1e03452
).
Files with missing lines | Patch % | Lines |
---|---|---|
kernel/src/engine/default/filesystem.rs | 91.83% | 0 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This ensures that calls to
list_files
are returned sorted if aLocalFileSystem
ObjectStore
is used.It's not clean for a few reasons:
type_of
or similar. We have a foreign trait object that doesn't have anas_any
on it, so we can force the reference into anAny
which would allow us to useis
, and we can't add an implementation of something likeas_any
becausedyn ObjectStore
isn'tSized
. So this resorts toformat
ing the object at creation (sinceObjectStore
requiresDisplay
) and checking if it starts withLocalFileSystem
....Adds a test that when using local client things come back sorted now. Without these changes the test failed.
I think we should merge (or something like it) and then also see about adding a
list_sorted
andlist_with_offset_sorted
toObjectStore