search

delta-incubator / delta-kernel-rs

A native Delta implementation for integration with any query engine
Apache License 2.0
121 stars 32 forks source link

[chore] Update golden files for FFI invalid handle tests #346

Open scovich opened 1 week ago

scovich commented 1 week ago

At some point a compiler upgrade started producing more verbose diagnostics, but golden files were never updated to match. Update them now.

zachschuermann commented 1 week ago

looks like tests/invalid-handle-code/mut-clone-handle.rs still doesn't match?

scovich commented 1 week ago

looks like tests/invalid-handle-code/mut-clone-handle.rs still doesn't match?

Depends on the compiler version, methinks. @zachschuermann has a good point. Maybe we somehow need golden files that map to specific compiler versions?

Or maybe we just run once in a while like this, because they're anyway only verifying that the compiler blocks users attempting Bad Things. Even if the compiler ever failed to block them, they're still doing it wrong and should stop.

zachschuermann commented 1 week ago

@scovich yea maybe the simplest thing for now is to try to freeze the golden file tests to run against a specific version of rustc? wonder if that's possible