Open zachschuermann opened 1 week ago
Attention: Patch coverage is 94.67085%
with 17 lines
in your changes missing coverage. Please review.
Please upload report for BASE (
main@266e9b4
). Learn more about missing BASE report. Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
need to make all properties Options. why? for propagating unchanged in write. e.g. if appendOnly is omitted we want to omit in the write (not write its default)
What changes are proposed in this pull request?
New
TableProperties
struct parses theMetadata
action'sconfiguration
into a strongly-typed configuration struct. Then, throughout the kernel we can leverage the configuration to appropriately handle DVs, column mapping, etc.Pragmatically, the changes are:
TableProperties
struct along with newSnapshot::get_table_properties()
APIDeserialize
implementations derived forTableProperties
and its fieldsTODOs
delta.appendOnly
is omitted, do we want the fieldTableProperties.append_only
to beNone
or default tofalse
?This PR affects the following public APIs
Snapshot::column_mapping_mode()
in favor of unifying underSnapshot::get_table_properties().get_column_mapping_mode()
How was this change tested?
more testing TODO!
Credit: @roeap for the original PR which this is based on #222