search

delta-io / delta-kernel-rs

A native Delta implementation for integration with any query engine
Apache License 2.0
144 stars 41 forks source link

Fix `read_table` compilation on windows #455

Closed nicklan closed 1 week ago

nicklan commented 1 week ago

What changes are proposed in this pull request?

Make read_table actually compile on windows.

  1. Add a strndup implementation for windows (thanks @hntd187)
  2. Fix some types that the windows compiler doesn't like
  3. Update CMakeLists.txt with correct things (thanks @hntd187 again)
  4. Update the README with some minimal instructions.

How was this change tested?

Built and run on windows (without PRINT_DATA)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.08%. Comparing base (bd2ea9f) to head (f1a9e94). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #455 +/- ## ======================================= Coverage 78.08% 78.08% ======================================= Files 55 55 Lines 11605 11605 Branches 11605 11605 ======================================= Hits 9062 9062 Misses 2043 2043 Partials 500 500 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.