search

delta-io / delta-kernel-rs

A native Delta implementation for integration with any query engine
Apache License 2.0
144 stars 41 forks source link

Simplify and clarify column name parsing logic #467

Closed scovich closed 1 day ago

scovich commented 1 week ago

What changes are proposed in this pull request?

It turns out our column name parsing code was unnecessarily complex. Simplify it and also use named values instead of "magic constants" for '.', ',', and '`' (which are remarkably similar and hard to read).

How was this change tested?

Existing unit tests.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 87.30159% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (67cc099) to head (95a5368). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/expressions/column_names.rs 87.30% 2 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #467 +/- ## ========================================== - Coverage 79.82% 79.78% -0.05% ========================================== Files 57 57 Lines 12591 12563 -28 Branches 12591 12563 -28 ========================================== - Hits 10051 10023 -28 Misses 2006 2006 Partials 534 534 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.