search

delta-io / delta-kernel-rs

A native Delta implementation for integration with any query engine
Apache License 2.0
144 stars 41 forks source link

derive Debug/Clone/Eq for `DvInfo` and `Stats` plus a few cleanups #468

Closed zachschuermann closed 1 week ago

zachschuermann commented 1 week ago

title.

breaking changes: (1) DvInfo now implements Clone, PartialEq, and Eq (2) Stats now implements Debug, Clone, PartialEq, and Eq

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.95%. Comparing base (cb47305) to head (ecb9e5e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #468 +/- ## ========================================== - Coverage 78.95% 78.95% -0.01% ========================================== Files 56 56 Lines 12216 12214 -2 Branches 12216 12214 -2 ========================================== - Hits 9645 9643 -2 Misses 2052 2052 Partials 519 519 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zachschuermann commented 1 week ago

Change seems fine, but what motivates the extra derivations, out of curiosity?

Ah @nicklan had the same question - should have given a better PR description :) @sppalkia pointed out that when trying to leverage DvInfo in his own code it was a bit of a 'sharp edge' to not derive some common traits like Clone