search

delta-io / delta-kernel-rs

A native Delta implementation for integration with any query engine
Apache License 2.0
144 stars 41 forks source link

fix test_write_parquet expected size #478

Closed zachschuermann closed 3 days ago

zachschuermann commented 3 days ago

little fix to remove our hardcoded expected_size

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.54%. Comparing base (9861282) to head (b7c2095). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/engine/default/parquet.rs 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #478 +/- ## ========================================== - Coverage 79.54% 79.54% -0.01% ========================================== Files 56 56 Lines 12256 12259 +3 Branches 12256 12259 +3 ========================================== + Hits 9749 9751 +2 Misses 1981 1981 - Partials 526 527 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zachschuermann commented 3 days ago

One question -- this looks so simple; why did the other PR not just do the same?

This was just an oversight on my part :) I missed it since it wasn't failing in my local tests