search

delta-io / delta-kernel-rs

A native Delta implementation for integration with any query engine
Apache License 2.0
144 stars 41 forks source link

Add boundary test cases for UUID length and file extensions #485

Closed hackintoshrao closed 17 hours ago

hackintoshrao commented 2 days ago

This PR adds explicit boundary test cases to existing tests:

  1. In test_uuid_checkpoint_patterns:

    • Tests UUID with exactly 35 characters (one too short)
    • Uses realistic UUID format: "3a0d65cd-4056-49b8-937b-95f9e3ee90e"

  2. In test_unknown_invalid_patterns:

    • Tests file with no extension (returns Ok(None))
    • Tests file with empty extension "." (returns Ok(Some) with Unknown type)
codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (a8ed99f) to head (0d5ae77).

Files with missing lines Patch % Lines
kernel/src/path.rs 64.70% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #485 +/- ## ========================================== - Coverage 80.22% 80.20% -0.03% ========================================== Files 61 61 Lines 13327 13342 +15 Branches 13327 13342 +15 ========================================== + Hits 10692 10701 +9 - Misses 2090 2094 +4 - Partials 545 547 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zachschuermann commented 1 day ago

@hackintoshrao can you update this PR with the latest changes in main (rebase/merge) and then we can merge it :)