Closed OussamaSaoudi-db closed 1 day ago
Attention: Patch coverage is 90.15625%
with 63 lines
in your changes missing coverage. Please review.
Project coverage is 80.20%. Comparing base (
4ad2f8b
) to head (358ed16
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What changes are proposed in this pull request?
This introduces two methods to construct
LogSegment
. The first is constructing LogSegment for Snapshots usingLogSegment::for_snapshot
. The second constructs LogSegment for the upcomingTableChanges
type.This PR also refactors log listing functions to reduce duplication in the code. We do so by creating a function
get_parsed_log_files_iter
to list, filter, and parse log files.This adds a test function to
test-utils
calleddelta_path_for_multipart_checkpoint
. This function can be used to create a multipart checkpoint path.This replaces the changes proposed in #457
How was this change tested?
This change introduces tests for the following:
for_table_changes
fails when the start version > end_versionThis PR also adds an ignored test that checks for desired behaviour. The test
build_snapshot_with_missing_checkpoint_part_no_hint
checks that an incomplete checkpoint is not used in a LogSegment. A checkpoint is incomplete if it does not have all the parts specified inLogPathFileType::MultiPartCheckpoint.num_parts
.