delta-io / delta-rs

A native Rust library for Delta Lake, with bindings into Python
https://delta-io.github.io/delta-rs/
Apache License 2.0
1.98k stars 365 forks source link

chore: expose `files_by_partition` to public api #2533

Closed edmondop closed 2 weeks ago

edmondop commented 1 month ago

Description

This documentation describes the usage of files_by_partition but that API doesn't seem to be surfaced from the underlying rust implementation

github-actions[bot] commented 1 month ago

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

ion-elgreco commented 3 weeks ago

@edmondop can you fix the linting issues? Then we can merge it

edmondop commented 3 weeks ago

I fixed the linting, but I think I should add a test since I have grown the API surface before this get merged.

I submitted to verify if I was wrong in reading the documentation or if a method was missing from the public api

edmondop commented 3 weeks ago

@ion-elgreco looks also there is a flaky concurrency test

ion-elgreco commented 3 weeks ago

@edmondop let me know when you added the test