delta-io / delta-rs

A native Rust library for Delta Lake, with bindings into Python
https://delta-io.github.io/delta-rs/
Apache License 2.0
1.98k stars 365 forks source link

Only allow squash merge #2542

Open thomasfrederikhoeck opened 1 month ago

thomasfrederikhoeck commented 1 month ago

Description

Sometimes it appears that some PR are merged in with all the underlying commits which can create some noise on what was changed and it makes reverts harder. I believe squash merge should be enforced - I think this is the common way to go about for a lib like delta-rs.

image

https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

Use Case

Related Issue(s)

ion-elgreco commented 1 month ago

I think the default is squash and merge, but you can still select rebase and merge. Not sure why that sometimes is selected though

thomasfrederikhoeck commented 1 month ago

@ion-elgreco I think it is possible to disable all other kinds if you are the repo owner. I think that should be considered since right now commits on master (if not squash) doesn't directly link to PRs.