delta-io / delta-rs

A native Rust library for Delta Lake, with bindings into Python
https://delta-io.github.io/delta-rs/
Apache License 2.0
2.34k stars 414 forks source link

fix: decimal stat rounding overflow #2975

Closed gruuya closed 3 days ago

gruuya commented 2 weeks ago

Description

Try to detect the situation where floating point conversion rounds the integer value beyond the valid Decimal(scale, precision) range, and rollback to next smaller value towards 0.0.

Related Issue(s)

Closes #2974

Documentation

None

github-actions[bot] commented 2 weeks ago

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 97.14286% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (0434435) to head (3012da5). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/writer/stats.rs 97.14% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2975 +/- ## ======================================= Coverage 72.47% 72.47% ======================================= Files 128 128 Lines 40823 40857 +34 Branches 40823 40857 +34 ======================================= + Hits 29585 29613 +28 - Misses 9355 9356 +1 - Partials 1883 1888 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: