delta-io / delta-rs

A native Rust library for Delta Lake, with bindings into Python
https://delta-io.github.io/delta-rs/
Apache License 2.0
2.34k stars 414 forks source link

chore: refactor some of the writebuilder preconditions into the appropriate function #3022

Closed rtyler closed 28 minutes ago

rtyler commented 16 hours ago

This change also refactors the check_preconditions function itself to be a bit less redundant and even includes some unit tests! Holy smokes!

I'm going to stand up a few pull requests as I work through this refactor incrementally

Related to work on #2968

codecov[bot] commented 16 hours ago

Codecov Report

Attention: Patch coverage is 80.66667% with 29 lines in your changes missing coverage. Please review.

Project coverage is 72.68%. Comparing base (d82b9b3) to head (c85a390). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/operations/write.rs 80.66% 3 Missing and 26 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3022 +/- ## ========================================== + Coverage 72.65% 72.68% +0.03% ========================================== Files 128 128 Lines 41199 41318 +119 Branches 41199 41318 +119 ========================================== + Hits 29932 30033 +101 + Misses 9350 9340 -10 - Partials 1917 1945 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: