search

delta-io / delta

An open-source storage framework that enables building a Lakehouse architecture with compute engines including Spark, PrestoDB, Flink, Trino, and Hive and APIs
https://delta.io
Apache License 2.0
6.98k stars 1.6k forks source link

[PROTOCOL] Fix inline DV example in PROTOCOL.md #3063

Closed nicklan closed 3 weeks ago

nicklan commented 3 weeks ago

Which Delta project/connector is this regarding?

Description

The previous example was incorrect. It had the magic encoded in big-endian, but it should be little-endian. This fixes it.

To see that the previous one was incorrect, you can go to https://www.dcode.fr/ascii-85-encoding, and decode wi5b=000010000siXQKl0rr91000f55c8Xg0@@D72lkbi5=-{L (be sure to select the zeromq encoding). The first 4 bytes of this decode to 0x64, 0x39, 0xD3, 0xD0. This is 1681511376 (the correct magic), but only if you decode as Big endian.

The new value decodes to 0xD1 0xD3 0x39 0x64, which is 1681511377 in little Endian.

How was this patch tested?

Tested in this pr in the rust kernel

Does this PR introduce any user-facing changes?

felipepessoto commented 3 weeks ago

Is this duplicated? #2050

Fix #1905

nicklan commented 3 weeks ago

Is this duplicated? #2050

Fix #1905

Ohh yep, did not see that one. We should merge that one :)