search

delta-io / delta

An open-source storage framework that enables building a Lakehouse architecture with compute engines including Spark, PrestoDB, Flink, Trino, and Hive and APIs
https://delta.io
Apache License 2.0
7.62k stars 1.71k forks source link

[Infra] Include GitHub workflow name in each task #3644

Closed scottsand-db closed 2 months ago

scottsand-db commented 2 months ago

Which Delta project/connector is this regarding?

Description

I'd like to do some data science using the GitHub REST API on our PR runtimes.

Unfortunately, using the GitHub CHECKs API (https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#list-check-runs-for-a-git-reference), I only get the name of the individual job. Getting the name of the parent workflow requires an additional API call.

This is because our job names are the default job names right now for most of our GitHub workflows. This doesn't give us any info as to which workflow it is for. For example, today I'd get result test (2.13.13, 0) but I am unable to determine if this is for Delta Spark Latest or Delta Spark Master.

This PR updates the workflow job name to include the workflow name so now we can uniquely identify the jobs.

How was this patch tested?

CI tests.

Does this PR introduce any user-facing changes?

No

scottsand-db commented 2 months ago

It looks like I can see the new names in the CI that's running on this PR? Unfortunately this feels redundant - many have names like Delta Kernel Tests / Delta Kernel - any idea if we could alias somehow to shorten? if not then oh well probably worth the naming redundancy to do your science

@zachschuermann - no way that I know of. If this redundancy escalates to something more serious/concerning, we can revert this PR

tdas commented 2 months ago

The names in the UI are getting very very long and cut off. This aint great. Especially this Delta Spark Local Publishing and Examples Compilation / Delta Spark Local Publishing and Examples Compilation: Scala 2.13.13 (pull_request)

scottsand-db commented 2 months ago

The names in the UI are getting very very long and cut off. This aint great. Especially this Delta Spark Local Publishing and Examples Compilation / Delta Spark Local Publishing and Examples Compilation: Scala 2.13.13 (pull_request)

@tdas - ACK, I pushed a new commit with shortened names