Closed clarkzinzow closed 7 months ago
cc @dennyglee
Name | Link |
---|---|
Latest commit | 66278e0e4589226b3499504e443792e519726e10 |
Latest deploy log | https://app.netlify.com/sites/delta-io-beta/deploys/661464f7decf5a0008ebcb46 |
Deploy Preview | https://deploy-preview-390--delta-io-beta.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks very much for submitting this PR @clarkzinzow! I'll properly review this shortly - one thing I noticed immediately is that the preview thumb nail on the front page looks a little off.
@dennyglee Indeed, I'll work on fixing the spacing for some of the images!
@dennyglee I've fixed the spacing in the images and updated some of the copy. It appears that the docs preview build doesn't automatically trigger on new commits, do we need to do anything to trigger another build?
Just triggered the build, will review later.
This is looking great @clarkzinzow. super minor nit, so feel free to disregard - perhaps have the splash screen of your blog on the front screen be this image? It's the right size (and matches the other splash screens) and its really compelling, eh?!
As noted, feel free to disregard! let me know if you want me to approve and merge or if you want to update, I'll wait before final approval and merging.
Hey @dennyglee, great idea! I'm going to update the thumbnail to be the image you linked to, after I change the chart title to "Query speedup vs JSON with Daft" and a "higher is better" note under the chart.
@dennyglee Updated with a new thumbnail and a top-of-page landing image that we're thinking about adding, could you kick off another build?
Kicked off and approved! Please do a quick sanity check and I’ll merge. Thanks !
On Mon, Apr 8, 2024 at 12:29 Clark Zinzow @.***> wrote:
@dennyglee https://github.com/dennyglee Updated with a new thumbnail and a top-of-page landing image that we're thinking about adding, could you kick off another build?
— Reply to this email directly, view it on GitHub https://github.com/delta-io/website/pull/390#issuecomment-2043502578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALBHLJ5ZMQV2JFBX3OWZU3Y4LVZZAVCNFSM6AAAAABFYIPD22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGUYDENJXHA . You are receiving this because you were mentioned.Message ID: @.***>
@dennyglee I just made some final tweaks to the benchmarking setup info formatting, good to merge when you are!
Love it @clarkzinzow - merging now!
This PR adds a blog post for distributed + parallel reading of large Delta Lake tables with Daft.