search

delta-rho / RHIPE

R and Hadoop Integrated Programming Environment
58 stars 28 forks source link

Changes to make RHIPE work CDH5 RHEL #11

Closed saptarshiguha closed 9 years ago

saptarshiguha commented 10 years ago
  1. Changed build.xml to use R CMD build (failed on Linux/RHEL)
  2. rherrors can read output of rhwatch(..., read=FALSE) to read the errors folder using the new dump frames options
  3. rhJobInfo, rhstatus and rhwatch correctly get the jobid (uses the Java MapReduce API)
  4. rhstatus (inside FileUtils) to return jobid (no need to use regex parsing)
hafen commented 10 years ago

Excellent! Thanks Saptarshi. Since we don't have an automatic testing procedure in place, did you by chance run through the tests in / src / test / R / install-test ? I think there is a way to do this as part of the ant build, but I don't see it documented in the README. @rperko3 or @amwhite, would you be able to elaborate on the correct way to run the tests?

saptarshiguha commented 10 years ago

Would be happy to run the tests. Is there an official approach?

hafen commented 10 years ago

I think the current approach is the following:

library(testthat)
test_package("Rhipe")

To see what is going on, several test scripts are supplied with the package, located here:

list.files(file.path(system.file(package = "Rhipe"), "tests", "testthat"))

If you want to selectively run only some of them, you can try the following, for example:

test_package("Rhipe", "simple-mr")

@amwhite might have more input.

amwhite commented 10 years ago

I’m not entirely sure the tests are set up in the way that test_package will work (they’re required to be in a specific directory for that). If not, you can use the test_dir or test_file functions instead on any file in the src/test/R/install-test directory.

Amanda

From: hafen [mailto:notifications@github.com] Sent: Monday, October 27, 2014 5:41 PM To: tesseradata/RHIPE Cc: White, Amanda M Subject: Re: [RHIPE] Changes to make RHIPE work CDH5 RHEL (#11)

I think the current approach is the following:

library(testthat)

test_package("Rhipe")

To see what is going on, several test scripts are supplied with the package, located here:

list.files(file.path(system.file(package = "Rhipe"), "tests", "testthat"))

If you want to selectively run only some of them, you can try the following, for example:

test_package("Rhipe", "simple-mr")

@amwhitehttps://github.com/amwhite might have more input.

— Reply to this email directly or view it on GitHubhttps://github.com/tesseradata/RHIPE/pull/11#issuecomment-60693921.