deltaDAO / nautilus

The Data Economy TypeScript Toolkit
https://nautilus.delta-dao.com
Apache License 2.0
4 stars 2 forks source link

[BUG] Pricing not showing well after publishing a dataset using nautilus #144

Closed freevedo33 closed 3 months ago

freevedo33 commented 3 months ago

Summary

Maybe not a bug. Hi everyone. When trying to publish a dataset with a specific price using nautilus, I noticed that the price showed later on the marketplace catalogue does not appear well. For example, when given 1 Ocean, in the catalogue the price will be 1.001 Ocean. When I use the editPrice function, it seems to work fine.

Maybe it is an understanding problem my side.

Current Behavior

Price is 1.001 Ocean

Expected Behavior

1 Ocean

Steps to Reproduce

Here you can see my pricing config:

export const PRICING_CONFIGS: PricingConfig = {

  [Network.PONTUSX]: {

    FREE: {

      type: 'free'

    },

    FIXED_OCEAN: {

      type: 'fixed',

      freCreationParams: {

        fixedRateAddress: '0xAD8E7d2aFf5F5ae7c2645a52110851914eE6664b',

        baseTokenAddress: '0x0995527d3473b3a98c471f1ed8787acd77fbf009',

        baseTokenDecimals: 18,

        datatokenDecimals: 18,

        fixedRate: '1',

        marketFee: '0',

        marketFeeCollector: '0x0000000000000000000000000000000000000000'

      }

    },

    FIXED_EUROE: {

      type: 'fixed',

      freCreationParams: {

        fixedRateAddress: '0xAD8E7d2aFf5F5ae7c2645a52110851914eE6664b',

        baseTokenAddress: '0xe974c4894996E012399dEDbda0bE7314a73BBff1',

        baseTokenDecimals: 6, // adapted for EUROe decimals

        datatokenDecimals: 18,

        fixedRate: '1',

        marketFee: '0',

        marketFeeCollector: '0x0000000000000000000000000000000000000000'

      }

    }

  },

Maybe I should change something in the configuration.

Environment

Anything else

kaimeinke commented 3 months ago

Hi @freevedo33 , this is in fact not a bug and has nothing to do with your local configuration. You specified the price of the service provider correctly with 1.000, but the market fee of 0,1% is added with an amount of 0.001, which sums up to a total of 1.001.

image

For every asset you will see a cost breakdown when hovering over the info icon.

image

When observing the transaction itself, you will see that the fee is being substracted from the paid amount automatically which is part of the incentive system for the base services of the ecosystem to support sustainable operations for the ecosystem providers.

Example: https://explorer.pontus-x.eu/tx/0x02db1af6a043b4579868cc9e94f5d55a0ec677a31f3657392d293b61a15b8fe0

freevedo33 commented 3 months ago

Hi @freevedo33 , this is in fact not a bug and has nothing to do with your local configuration. You specified the price of the service provider correctly with 1.000, but the market fee of 0,1% is added with an amount of 0.001, which sums up to a total of 1.001.

image

For every asset you will see a cost breakdown when hovering over the info icon.

image

When observing the transaction itself, you will see that the fee is being substracted from the paid amount automatically which is part of the incentive system for the base services of the ecosystem to support sustainable operations for the ecosystem providers.

Example: https://explorer.pontus-x.eu/tx/0x02db1af6a043b4579868cc9e94f5d55a0ec677a31f3657392d293b61a15b8fe0

Hi @kaimeinke,

Thank you for your answer. Now I understand it.

Is there any community channels that I can use for questions about to nautilus ? like discord. Sometimes I don't have issues but only questions about the structure of nautilus.

Thanks.