deltachat-bot / bot-pages

Source of bots.delta.chat
https://bots.delta.chat
GNU General Public License v3.0
3 stars 0 forks source link

bulma fixes #30

Closed lefherz closed 4 years ago

lefherz commented 4 years ago

related to #2

fixing the bottom-padding was actually quite easy. I'm convinced of bulma. Let's see how it is with the menu on mobile.

github-actions[bot] commented 4 years ago

Response from respost

Check out the page preview at https://staging.bots.delta.chat/30/

lefherz commented 4 years ago

Unfortunately I needed to use one property which only exists on Firefox - the effect is not even that ugly, but maybe someone else has a different solution to reduce the width of the menu link background to the width of the menu link?

pabzm commented 4 years ago

Thanks for the padding fix!

I don't agree to the menu changes, though, see my other comment.

lefherz commented 4 years ago

Not sure, the menu looks a bit unconventional in chromium, but not necessarily bad...

Screenshot_2020-03-13_16-43-24

we could just remove this part, so it looks the same on all browsers:

diff --git a/assets/styles/main.scss b/assets/styles/main.scss
index 00b8dbf..a8831b7 100644
--- a/assets/styles/main.scss
+++ b/assets/styles/main.scss
@@ -43,10 +43,5 @@ div.highlighter-rouge {
   .content h1 {
     display: inline-block;
   }
-  .menu-list a.is-active {
-    max-width: -moz-max-content;
-    margin-left: auto;
-    margin-right: 0;
-  }
 }
Simon-Laux commented 4 years ago

Please check again if you need that much padding. I turned of the padding in .column and the site looked better IMHO on mobile.

lefherz commented 4 years ago

Please check again if you need that much padding. I turned of the padding in .column and the site looked better IMHO on mobile.

agreed, fixed.

pabzm commented 4 years ago

You're right, it's good enough as an improvement. The details don't matter that much.