deltachat-bot / deltabot

Delta.Chat bot written in Python
Mozilla Public License 2.0
33 stars 18 forks source link

acc.configure's syntax may be wrong #43

Closed kijetasantakalu closed 1 year ago

kijetasantakalu commented 3 years ago

Could very well be my fault, I might have overlooked something, but in case it's not, here's an error when I ran "deltabot init " , File "/opt/virtualenvs/python3/lib/python3.8/site-packages/deltabot/cmdline.py", line 42, in init acc.configure(addr=emailadr, mail_pw=password) TypeError: configure() got an unexpected keyword argument 'addr'

genya1 commented 3 years ago

Took a look at the configure() binding function here and there is no keyword arguments addr or mail_pw. I tried to rewrite the code from

acc.configure(addr=emailadr, mail_pw=password)

to

acc.set_config("addr", emailadr)
acc.set_config("mail_pw", password)

this works but the next problem is that there is no function start_threads() in the Account class. Is this function a todo item or did I install something incorrectly ? The README says it should work so I am confused.

genya1 commented 3 years ago

I figured out what the issue was for me, the deltachat-core-rust library is not in sync with the bot library, meaning there was a major update to the deltachat-core-rust and it should work if both libraries are up to date. Keep in mind the bot uses the default email settings, so if you require custom port / server name / security it will just hang on the init command. I created a proposal to solve this here

link2xt commented 1 year ago

This was fixed by d3761e842b9f19d92e6a4f050297ad490ebc4141, line with outdated configure call is not in the repo anymore.